Skip to content

Add separate builds for Pico and Pico 2 W to GiHub CI #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

lurch
Copy link
Contributor

@lurch lurch commented Apr 26, 2025

Many of the pico-examples are RP2350 only, so add a Pico 2 W build job so that these (and the wireless-only examples) get test-built too

Many of the pico-examples are RP2350 only, so add a Pico 2 W build job so that these (and the wireless-only examples) get test-built too
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth using a matrix instead (ie run separate jobs for each board)? This has the advantage of making it easier to add other boards in future and reducing duplication, but the disadvantage that it'll require cloning the SDK separately for each job (so ~30s extra total execution time, plus a bit of overhead as both jobs run sequentially on the same runner).

@lurch
Copy link
Contributor Author

lurch commented Apr 28, 2025

Feel free to hack my PR about to do whatever you think is best 😀

Many of the pico-examples are RP2350 only, so add a Pico 2 W build job so that these (and the wireless-only examples) get test-built too
@lurch
Copy link
Contributor Author

lurch commented Apr 29, 2025

Cool, now looks much neater than my hacky attempt 🤩

@will-v-pi
Copy link
Contributor

I'll just push a couple more commits to fix up the action, while I'm here

@lurch
Copy link
Contributor Author

lurch commented Apr 29, 2025

I'll just push a couple more commits to fix up the action, while I'm here

Let me know when you want the green-approval tick 😀

@lurch
Copy link
Contributor Author

lurch commented Apr 29, 2025

Is it worth doing this matrix thing for the Mac and Windows builds too, or would that just be overkill?
Is it worth trying to do a RISC-V build of the examples also? 🤷

@will-v-pi
Copy link
Contributor

will-v-pi commented Apr 29, 2025

Is it worth doing this matrix thing for the Mac and Windows builds too, or would that just be overkill? Is it worth trying to do a RISC-V build of the examples also? 🤷

I think the Mac and Windows builds are probably fine without, because I think it's very unlikely that any particular example could be broken on one OS but not others (unlike picotool, where it does matrix everything across all OSes because it's easy to break one of them). I think it would also add a lot more overhead, as the dependency installation takes longer on Mac and Windows

Risc-V is a good idea, but that will need @liamfraser to install a Risc-V toolchain on the runner

@lurch
Copy link
Contributor Author

lurch commented Apr 29, 2025

... or @lloydalexporter ?

@lurch
Copy link
Contributor Author

lurch commented May 1, 2025

With a sideways glance at #643 perhaps it is worth expanding this to build for each of Pico, Pico W, Pico 2 & Pico 2 W ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants