Conversation
naushir
force-pushed
the
ruff
branch
4 times, most recently
from
6aee5f8 to
fb1afdb
Compare
Collaborator
Author
|
@davidplowman here's a first pass to look at. |
Replace flake8 (plus 10 plugins) and pylint with ruff for both CI and pre-commit hooks. The new CI workflow uses astral-sh/ruff-action and no longer needs to build libcamera/kmsxx since ruff doesn't import project code. - Add pyproject.toml with ruff configuration - Add .github/workflows/ruff.yml (replaces flake8.yml) - Update .pre-commit-config.yaml to use ruff hooks - Update requirements-test.txt (11 deps removed, ruff added) - Delete .flake8, .pylintrc, .github/workflows/flake8.yml - Add .ruff_cache/ to .gitignore Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Run ruff format across the entire codebase and fix lint violations that ruff catches but flake8 did not: - B904: Add 'from err' to re-raises in except blocks - E721: Use 'is' instead of '==' for type comparisons - E741: Rename ambiguous variable name 'l' to 'lo' - I001: Sort import blocks Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Move all package metadata from setup.py to pyproject.toml using PEP 621 declarative format. Use setuptools as the build backend with automatic package discovery for picamera2*. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.