Add support for BoyaMicroelectronics BY25Q16AW spi flash, Fix errors with -Werror=calloc-transposed-args #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #126
Sounds like you'll find https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-and-deleting-branches-within-your-repository helpful then 🙂 |
|
I did see the pull request for BYQ16B, it appears to be a similar device but has a different id. |
|
Yeah, I was just suggesting that if / when support for the BY25Q16AW gets merged, it probably makes sense to merge support for the BYQ16B at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for BY25Q16AW spi flash id 0x00151068, found on a Aliexpress pico w.
Fix errors compiling with -Werror=calloc-transposed-args which now seems to be a default flag on my system.
This seems to be fixed upstream in commit 400cf2 https://sourceforge.net/p/openocd/code/ci/400cf213c05d17cede4dca4787a5533959bd2183/.
Sorry I couldn't find a easy way to split this into separate commits. Its probably better just to patch spi.c and pull the -Werror=calloc-transposed-args fix from upstream.