media/hevc_d: Do not reject slice header with bad ref_idx entries - #7620
Merged
pelwell merged 1 commit intoSep 15, 2026
Merged
Conversation
The previous patch to hevc_d checked that the entries in ref_idx were legal and rejected the slice header if not. Unfortunately gstreamer marks missing frames in this manner and expects decode to continue. Stop rejecting the header and produce a sanitized copy of ref_idx_lX that we use for the decode. Signed-off-by: John Cox <jc@kynesim.co.uk>
6by9
approved these changes
Sep 15, 2026
6by9
left a comment
6by9
left a comment
Contributor
There was a problem hiding this comment.
@popcornmix I'm not expecting you to be too fussed over this one as it is covering invalid streams (references to invalid reference frames), but you might want to review or test it.
Collaborator
|
I do have this in my home kodi build, and I've not seen any issue. |
Contributor
|
Good enough for me. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 15, 2026
kernel: drm/mipi-dbi: display a cropped region of an oversized framebuffer See: raspberrypi/linux#7589 kernel: media: i2c: imx296: Add strobe outputs, controlled by module parameters See: raspberrypi/linux#7606 kernel: Correctly unbind CFE See: raspberrypi/linux#7624 kernel: media/hevc_d: Do not reject slice header with bad ref_idx entries See: raspberrypi/linux#7620
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 15, 2026
kernel: drm/mipi-dbi: display a cropped region of an oversized framebuffer See: raspberrypi/linux#7589 kernel: media: i2c: imx296: Add strobe outputs, controlled by module parameters See: raspberrypi/linux#7606 kernel: Correctly unbind CFE See: raspberrypi/linux#7624 kernel: media/hevc_d: Do not reject slice header with bad ref_idx entries See: raspberrypi/linux#7620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous patch to hevc_d checked that the entries in ref_idx were legal and rejected the slice header if not. Unfortunately gstreamer marks missing frames in this manner and expects decode to continue. Stop rejecting the header and produce a sanitized copy of ref_idx_lX that we use for the decode.
Tested with a hacked ffmpeg that corrupted the ref_idx_lX entries on a regular basis.