feat: add RBAC support #469
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitrgadiya
force-pushed
the
feat/rbac-support
branch
from
a8aa9be to
ab19903
Compare
|
🤖 Pull Request Artifacts (#19133019304) 🎉 |
ankitrgadiya
force-pushed
the
feat/rbac-support
branch
8 times, most recently
from
7e43629 to
7b5f0e0
Compare
…rove error handling
…mprove data access
…d improve data handling
…thods and improve data access
guptadev21
force-pushed
the
feat/rbac-support
branch
from
1333910 to
9e55138
Compare
…nd dependency changes
… consistency and clarity
…n with walk_pages
…ss config tree operations
…nd dependency changes
… consistency and clarity
… scenarios - Updated test method names for better clarity and organization. - Introduced extended role tests for secret-creator, secret-manager, secret-readonly, and secret-deleter roles. - Added complex scenarios to test combined permissions for users with multiple roles. - Implemented boundary validation tests for secret name patterns. - Enhanced cleanup process to unbind all roles and delete test resources. - Improved documentation within the test module for better understanding of test execution order and scenarios.
…ent manifests - Changed the binding structure in `bind.py` to include `newBindings` and `oldBindings`. - Updated the `unbind.py` to reflect the new binding structure. - Modified the `model.py` to streamline role updates by removing unnecessary parameters. - Cleaned up imports in `model.py` and `util.py`. - Removed obsolete manifest files related to deployments, disks, networks, role bindings, user groups, and values. - Added new package manifests for boundary testing and role management. - Updated test cases to reflect changes in package and secret management. - Removed redundant code in test files for better clarity and maintainability.
guptadev21
force-pushed
the
feat/rbac-support
branch
from
11ebb5f to
42be0f0
Compare
- Updated usergroup manifest structure to use `roleNames` instead of `roles` for member role assignments. - Changed role assignment in usergroup schema to reflect new naming conventions. - Enhanced error handling in the Applier class to skip None objects during manifest loading. - Updated package model methods to use new API client methods for user groups. - Refactored usergroup inspection and listing commands to align with updated API methods. - Added new usergroup test cases to validate RBAC functionality for secrets, packages, and static routes. - Created new test manifests for usergroups and secrets to support RBAC testing. - Cleaned up old test cases and added comprehensive cleanup methods for usergroups and resources.
- Updated deployment list display to use `name_or_guid` instead of `nameOrGUID`. - Changed executable status attribute from `executablesStatus` to `executables_status`. - Added new role definitions for deployment RBAC testing in `deployment-roles.yaml`. - Created test deployments and managed deployments in `managed-deployments.yaml` and `test-deployments.yaml`. - Introduced test packages for deployments in `test-packages-for-deployments.yaml`. - Implemented comprehensive RBAC tests for deployment operations, including role binding and permissions checks for different user roles. - Added cleanup methods to remove test resources and role bindings after tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.