Skip to content

Enhancement: Update Core UI to 1.0.6 #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2018
Merged

Enhancement: Update Core UI to 1.0.6 #1001

merged 3 commits into from
Jan 24, 2018

Conversation

bambamboole
Copy link
Contributor

I just compared the swapped out the sass files and updated yarn.lock.

Can't see any major changes or broken things in the backend so this should just work.

I saved the logo in resources and removed the image in public.
We should avoid to commit any resources that can be build with laravel mix.

btw: this resolves #975

@rappasoft
Copy link
Owner

There seems to be other things in here not directly related to coreui, like removing pace and global overrides? You need to explain why so I have something to link to when people ask.

@bambamboole
Copy link
Contributor Author

@rappasoft
I tried to use pace-progress in favor of pace, because with pace-progress there would be an npm package. But there is an issue with it (click me) .

So I built it back but changed the require parameter because there doesn't have to be the whole path to node_modules. the package name is enough.
The reason for a new yarn.lock was the yarn update command.

@rappasoft rappasoft merged commit 184f220 into rappasoft:master Jan 24, 2018
@bambamboole bambamboole deleted the feature-update-core-ui branch January 24, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: CoreUI version outdated?
2 participants