Add basic metrics to channels - #1207
Open
wence- wants to merge 3 commits into
Open
Conversation
TomAugspurger
approved these changes
Sep 9, 2026
TomAugspurger
left a comment
TomAugspurger
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks. Just a question on the names in the MetricsSnapshot but the proposed ones are fine too.
On send/receive the byte count of messages is recorded. These can be obtained for inspection at a point in time by accessing the metrics() of a channel.
wence-
force-pushed
the
wence/fea/1200
branch
from
September 9, 2026 17:23
a77adca to
4415df4
Compare
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to track message count and message volume.
By separating the send and receive side of the channel we can track if any message was spilled in the channel.
Channel.send/Channel.recv#1200