Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dependencies.yaml File #8

Closed
wants to merge 0 commits into from
Closed

Add a dependencies.yaml File #8

wants to merge 0 commits into from

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Oct 18, 2024

Closes https://github.com/rapidsai/graph_dl/issues/633

This PR creates a dependencies.yaml file for the new nx-cugraph repo

Notes for reviewers:

  • The file was mainly derived from my own understanding of the file, and uses the same naming conventions/packages from cugraph
  • After running rapids-dependency-file-generator the pyproject.toml file was modified

@nv-rliu nv-rliu added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 18, 2024
@nv-rliu nv-rliu added this to the 24.12 milestone Oct 18, 2024
@nv-rliu nv-rliu self-assigned this Oct 18, 2024
@nv-rliu nv-rliu requested review from raydouglass, bdice, ajschmidt8 and rlratzel and removed request for raydouglass October 18, 2024 19:23
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without knowing much about nx-cugraph's dependencies, I don't see any glaring issues.

LGTM.

dependencies.yaml Outdated Show resolved Hide resolved
python/nx-cugraph/pyproject.toml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we re-add test_notebook to dependencies.yaml? We do have demo notebooks for nx-cugraph, but I don't know if they're regularly executed during CI.

Also, should we add depends_on_cudf to test_python_nx_cugraph since we recently added this test to nx-cugraph:
https://github.com/rapidsai/cugraph/blob/2ac5586c8939bc371e3637f8e3e5a972b02bf0ef/python/nx-cugraph/nx_cugraph/tests/test_convert_matrix.py#L34-L67

@nv-rliu
Copy link
Contributor Author

nv-rliu commented Oct 21, 2024

@eriknw

Should we re-add test_notebook to dependencies.yaml? We do have demo notebooks for nx-cugraph, but I don't know if they're regularly executed during CI.

I assume we intend on testing notebooks in CI for nx-cugraph so I'll go ahead and add test_notebook in.

Also, should we add depends_on_cudf to test_python_nx_cugraph since we recently added this test to nx-cugraph:
https://github.com/rapidsai/cugraph/blob/2ac5586c8939bc371e3637f8e3e5a972b02bf0ef/python/nx-cugraph/nx_cugraph/tests/test_convert_matrix.py#L34-L67

Ah, I wasn't aware of this dependency. Was this a recent change to cugraph? I think the nxcg repo was last updated around the time code-freeze for 24.10 began.

@nv-rliu
Copy link
Contributor Author

nv-rliu commented Oct 21, 2024

I made the suggested changes and re-requested your reviews. Thank you

@github-actions github-actions bot added the ci label Oct 21, 2024
dependencies.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@nv-rliu nv-rliu requested a review from eriknw October 21, 2024 21:16
@nv-rliu nv-rliu closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants