-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dependencies.yaml
File
#8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without knowing much about nx-cugraph
's dependencies, I don't see any glaring issues.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we re-add test_notebook
to dependencies.yaml? We do have demo notebooks for nx-cugraph, but I don't know if they're regularly executed during CI.
Also, should we add depends_on_cudf
to test_python_nx_cugraph
since we recently added this test to nx-cugraph:
https://github.com/rapidsai/cugraph/blob/2ac5586c8939bc371e3637f8e3e5a972b02bf0ef/python/nx-cugraph/nx_cugraph/tests/test_convert_matrix.py#L34-L67
I assume we intend on testing notebooks in CI for nx-cugraph so I'll go ahead and add
Ah, I wasn't aware of this dependency. Was this a recent change to cugraph? I think the nxcg repo was last updated around the time code-freeze for 24.10 began. |
I made the suggested changes and re-requested your reviews. Thank you |
Closes https://github.com/rapidsai/graph_dl/issues/633
This PR creates a
dependencies.yaml
file for the new nx-cugraph repoNotes for reviewers:
rapids-dependency-file-generator
thepyproject.toml
file was modified