VPQ Dataset: write codes one word at a time during building #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
achirkin
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
cjnolet
approved these changes
Nov 4, 2025
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
Moving this to draft: although the write efficiency improves by 2-5x according to the nsight profiler (less store instructions), the overall kernel runtime barely changes at all, because the bottleneck is data reading and ALU (encoding). So the value of the PR is in question. |
lowener
reviewed
Nov 5, 2025
| if (filled_bits >= BitsPerLabel) { | ||
| filled_bits -= BitsPerLabel; | ||
| // write the codes to global memory | ||
| *out_codes_ptr++ = staging_codes; |
Contributor
There was a problem hiding this comment.
Moving the lane condition if (lane_id == 0) to only this line can improve warp parallelism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the efficiency of
process_and_fill_codes_kernelby writing the codes in larger chunks.