Skip to content

Use env var to disable long tests when run with racecheck #20755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 4, 2025
Merged

Use env var to disable long tests when run with racecheck #20755

merged 7 commits into from
Dec 4, 2025
+29 −5

Conversation

@davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Dec 1, 2025

Description

Modifies the LIBCUDF_MEMCHECK_ENABLED environment variable to include racecheck or synccheck appropriately so the gtests logic can skip long running tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Dec 1, 2025
@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 1, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 1, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

bdice
bdice reviewed Dec 1, 2025
View reviewed changes
@davidwendt
Copy link
Contributor Author

davidwendt commented Dec 3, 2025

/ok to test

@davidwendt davidwendt changed the title [EXP] Use env var to disable long tests when run with racecheck Use env var to disable long tests when run with racecheck Dec 3, 2025
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 3, 2025
@davidwendt davidwendt marked this pull request as ready for review December 3, 2025 14:49
@davidwendt davidwendt requested review from a team as code owners December 3, 2025 14:49
@davidwendt
Copy link
Contributor Author

davidwendt commented Dec 4, 2025

/merge

@rapids-bot rapids-bot bot merged commit 9ebb19b into rapidsai:main Dec 4, 2025
137 of 139 checks passed
@davidwendt davidwendt deleted the cs-disable-env-var branch December 4, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gforsyth gforsyth gforsyth approved these changes

@bdice bdice bdice approved these changes

@vuule vuule vuule approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/ci-codeowners

@devavret devavret Awaiting requested review from devavret devavret is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidwendt @gforsyth @bdice @vuule