-
Notifications
You must be signed in to change notification settings - Fork 989
Ensure IR.do_evaluate signature is correct #20647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomAugspurger
wants to merge
6
commits into
rapidsai:main
Choose a base branch
from
TomAugspurger:tom/do-evaluate-signature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ensure IR.do_evaluate signature is correct #20647
TomAugspurger
wants to merge
6
commits into
rapidsai:main
from
TomAugspurger:tom/do-evaluate-signature
+451
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aca4e15 to
23b09ed
Compare
dafbd04 to
6735598
Compare
Contributor
Author
|
/ok to test fb31b44 |
Contributor
Author
|
/ok to test 1c66ed3 |
TomAugspurger
commented
Nov 24, 2025
89cd12f to
fadafed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
cudf.pandas
Issues specific to cudf.pandas
cudf-polars
Issues specific to cudf-polars
Java
Affects Java cuDF API.
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the signature of our
IR.do_evaluatenodes to follow our convention of being a classmethod with*non_child_args, *children, *, contextIt also adds a new pre-commit hook to validate that our subclasses meet this requirement, by parsing the AST of our files defining IR nodes. Doing it incorrectly will result in errors like
Closes #20481