Skip to content

Remove hostdevice_vector::element due to unnecessary synchronization #19092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

Remove hostdevice_vector::element due to unnecessary synchronization #19092

merged 5 commits into from
Jul 23, 2025

Conversation

@JigaoLuo
Copy link
Contributor

@JigaoLuo JigaoLuo commented Jun 4, 2025 •
edited by mhaseeb123
Loading

Description

Contributes to #18967, part of #18968

In this PR, hostdevice_vector::element is removed due to its internal cudaMemcpy into host pageable memory. Also, the only call in it is replaced manually.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@JigaoLuo JigaoLuo requested a review from a team as a code owner June 4, 2025 21:15
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 4, 2025
mhaseeb123
mhaseeb123 previously requested changes Jun 4, 2025
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Adding a DO NOT MERGE label for now as the removed stuff is needed to reproduce the compiler segfault issue.

@mhaseeb123 mhaseeb123 added the DO NOT MERGE Hold off on merging; see PR for details label Jun 4, 2025
@JigaoLuo JigaoLuo changed the title Remove unnecessary synchronization (miss-sync) during Parquet reading (Part 2: hostdevice_vector::element) Remove hostdevice_vector::element due to unnecessary synchronization (Part 2 of miss-sync) Jun 5, 2025
@vuule vuule changed the title Remove hostdevice_vector::element due to unnecessary synchronization (Part 2 of miss-sync) Remove hostdevice_vector::element due to unnecessary synchronization (Part 2 of miss-sync) Jun 5, 2025
@JigaoLuo JigaoLuo requested a review from mhaseeb123 June 6, 2025 14:52
@JigaoLuo JigaoLuo mentioned this pull request Jun 8, 2025
Open
JigaoLuo
JigaoLuo commented Jul 18, 2025
View reviewed changes
@JigaoLuo
Copy link
Contributor Author

JigaoLuo commented Jul 18, 2025

Hi @mhaseeb123 , just wanted to check if any update on the bug that’s currently blocking the merge of this pull request? Thanks!

@mhaseeb123
Copy link
Member

mhaseeb123 commented Jul 22, 2025

Hi @mhaseeb123 , just wanted to check if any update on the bug that’s currently blocking the merge of this pull request? Thanks!

Unfortunately, I don't see any updates on the page. @GregoryKimball @vuule should we just move ahead with this PR and refer NVBug to use libcudf branch-25.08 (before this PR's commit) to reproduce the bug.

@JigaoLuo
Copy link
Contributor Author

JigaoLuo commented Jul 22, 2025

Thanks for the update! I’m happy to either leave it as is (for NVbug bookkeeping) or proceed with the merge—whichever option aligns with what we discussed.

@vuule
Copy link
Contributor

vuule commented Jul 22, 2025

I would be okay with letting this PR move along. Should not be too hard to recreate the repro even without the element function.

@mhaseeb123 mhaseeb123 added 4 - Needs Review Waiting for reviewer to review or respond and removed DO NOT MERGE Hold off on merging; see PR for details labels Jul 22, 2025
@mhaseeb123
Copy link
Member

mhaseeb123 commented Jul 22, 2025

Alrighty then, let's review this and merge

@mhaseeb123 mhaseeb123 requested a review from vuule July 22, 2025 22:30
@mhaseeb123 mhaseeb123 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 22, 2025
@mhaseeb123
Copy link
Member

mhaseeb123 commented Jul 22, 2025

/ok to test 8dc770e

@mhaseeb123 mhaseeb123 dismissed their stale review July 22, 2025 22:30

Moving the PR along

@mhaseeb123 mhaseeb123 moved this to Burndown in libcudf Jul 22, 2025
@mhaseeb123 mhaseeb123 changed the title Remove hostdevice_vector::element due to unnecessary synchronization (Part 2 of miss-sync) Remove hostdevice_vector::element due to unnecessary synchronization Jul 22, 2025
@JigaoLuo
Copy link
Contributor Author

JigaoLuo commented Jul 23, 2025

Thanks for approving it and updating the PR title!

vuule
vuule reviewed Jul 23, 2025
View reviewed changes
@mhaseeb123
Copy link
Member

mhaseeb123 commented Jul 23, 2025

/ok to test 729a8e9

@mhaseeb123 mhaseeb123 requested a review from vuule July 23, 2025 19:09
@mhaseeb123
Copy link
Member

mhaseeb123 commented Jul 23, 2025

/merge

@rapids-bot rapids-bot bot merged commit 4003e52 into rapidsai:branch-25.08 Jul 23, 2025
90 checks passed
@mhaseeb123 mhaseeb123 moved this from Burndown to Landed in libcudf Jul 23, 2025
@JigaoLuo JigaoLuo mentioned this pull request May 28, 2025
Draft
3 tasks
@GregoryKimball GregoryKimball removed this from libcudf Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@vuule vuule vuule approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@mhaseeb123 mhaseeb123

@JigaoLuo JigaoLuo

Labels

4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JigaoLuo @mhaseeb123 @vuule