-
Notifications
You must be signed in to change notification settings - Fork 983
Apply primitive row operators into hash join #18896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply primitive row operators into hash join #18896
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…on (#18925) Discovered while working on #18896, this PR adds `#pragma once` directives to eliminate redundant header inclusions and reduce compilation time. Authors: - Yunsong Wang (https://github.com/PointKernel) - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #18925
|
/ok to test |
|
/ok to test |
|
I’ve updated the PR to include only the hash join changes. @davidwendt @bdice could you please take another look? |
bdice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about detail, otherwise LGTM.
mhaseeb123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple comments at some branched paths would be appreciated.
|
/merge |
|
Benchmark numbers on H100 |
Description
Supersedes #15700
This PR updates hash join to leverage primitive row operators where applicable, resulting in performance improvements of 10% to 30%.
Checklist