Skip to content

add missing import of ellipse in morphology module #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release/25.12
Choose a base branch
from
Open

add missing import of ellipse in morphology module #968

wants to merge 2 commits into from

Conversation

@grlee77
Copy link
Contributor

@grlee77 grlee77 commented Nov 8, 2025

cucim.skimage.morphology.footprints.ellipse should also be available via cucim.skimage.morphology.ellipse like the other footprints

@grlee77 grlee77 added this to the v25.12.00 milestone Nov 8, 2025
@grlee77 grlee77 requested a review from a team as a code owner November 8, 2025 17:24
@grlee77 grlee77 added this to cucim Nov 8, 2025
@grlee77 grlee77 added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 8, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@grlee77 grlee77 force-pushed the grelee/add-missing-import branch from fe8b847 to d826651 Compare November 8, 2025 17:33
@gigony gigony changed the base branch from main to release/25.12 November 18, 2025 19:15
jakirkham
jakirkham reviewed Nov 18, 2025
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg! 🙏

Looks good

Should we test this is importable somehow? Either with its own test or tweaking an existing test to import from this location

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 19, 2025

Should we test this is importable somehow? Either with its own test or tweaking an existing test to import from this location

Sure, updated the existing tests to also import from this location (some test cases still use via the footprint submodule as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

cucim
Status: No status

Milestone

v25.12.00

Development

Successfully merging this pull request may close these issues.

2 participants

@grlee77 @jakirkham