Skip to content

Conversation

@dwelch-r7
Copy link
Contributor

Resolves #14902

Combines the ssh_login and ssh_login_pubkey modules for an improved user experience

There will be an accompanying Pro PR so I will draft this until we're sure Pro works with these changes

my setup for testing can be found here #20546

Verification Steps

  • Run the ssh_login module and gain a session with username/password
  • Run the module again and gain a session with a non-password protected private key (via KEY_PATH and PRIVATE_KEY)
  • Run the module again and gain a session with a password protected private key (via KEY_PATH and PRIVATE_KEY)


scanner.verbosity = :debug if datastore['SSH_DEBUG']

scanner.scan! do |result|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realising this section is very similar between the two login methods bar the slight different in printing, I can probably DRY this up too

@dwelch-r7 dwelch-r7 force-pushed the combine-ssh-login-modules branch from 2eb18cc to b29aba1 Compare November 18, 2025 16:16
@smcintyre-r7 smcintyre-r7 self-assigned this Nov 18, 2025
@dwelch-r7 dwelch-r7 force-pushed the combine-ssh-login-modules branch from b29aba1 to 95e62cf Compare November 19, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate ssh_login_pubkey and ssh_login modules

2 participants