Fix right-click Push button generating "Time: N/A (0%), Space: N/A (0%)" commit messages#90
Open
raghav-potdar wants to merge 1 commit into
Open
Conversation
…mmits msg with N/A stats
Author
|
This PR partly resolves Issue #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Right-clicking the Push button (to add a filename suffix like -bfs) produced commits with placeholder stats: Time: N/A (0%), Space: N/A (0%) - LeetHub.
Root Cause
LeetCodeV2.prototype.init() relies on window.leethubLastSubmissionId, which is only set by the network interceptor when a submission happens in the current page session. After a page reload (or any manual Push), it's undefined, so init() alerted and returned early without populating this.submissionData. parseStats() then silently fell through to a broken DOM scraper that produced N/A values.
Fix
In src/js/leetcode.js:
Added getLatestAcceptedSubmissionId() helper that queries LeetCode's questionSubmissionList GraphQL endpoint for the latest accepted submission of the current problem.
init() now falls back to that helper when no in-session submission ID exists, and throws (instead of alert+return) if no submission can be found — letting loader properly mark the upload as failed.
Tightened three this.submissionData != null guards in parseStats(), getCode(), and parseQuestion() to plain truthy checks.
Tested