Skip to content

Fix PHP 8.4 deprecations#363

Open
JeppeKnockaert wants to merge 2 commits intorap2hpoutre:masterfrom
JeppeKnockaert:fix-php84-deprecations
Open

Fix PHP 8.4 deprecations#363
JeppeKnockaert wants to merge 2 commits intorap2hpoutre:masterfrom
JeppeKnockaert:fix-php84-deprecations

Conversation

@JeppeKnockaert
Copy link

This PR removes implicitly nullable parameters because these result in deprecation warnings for PHP 8.4.

https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter

@PNardman
Copy link

  • 1 for merging this!

@PNardman
Copy link

PNardman commented Apr 7, 2025

Still waiting for this @rap2hpoutre can someone take a look? 🙇

@elminson
Copy link

elminson commented Apr 7, 2025

This need the version 8.4 added to the matrix to pass all the tests cases

php: [ 8.1, 8.2, 8.3 ]

please add it and I will take a look after all tests pass @JeppeKnockaert @PNardman

@JeppeKnockaert
Copy link
Author

Added it, everything seems to be green!

Copy link

@elminson elminson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so workflow can be executed

@sylouuu
Copy link

sylouuu commented Aug 7, 2025

Any update on this @rap2hpoutre ?

@PNardman
Copy link

Any updates?

@MaxKorlaar
Copy link

Hi @rap2hpoutre, do you need any help with this PR? We'd love to get rid of the deprecation warnings in our logs.

@PNardman
Copy link

@rap2hpoutre any updates here? Would be cool to get rid of the deprecation logs.

@sylouuu
Copy link

sylouuu commented Feb 11, 2026

Unfortunately, considering moving to https://github.com/spatie/simple-excel

@elminson
Copy link

Unfortunately, considering moving to https://github.com/spatie/simple-excel

@sylouuu what may works, you can fork the repo and apply the open prs you need, unfortunately he is busy (I guess) and can't take care of those open prs for now. If you need help with merging some prs that you need let me know I will help you with that.

@elminson
Copy link

Unfortunately, considering moving to https://github.com/spatie/simple-excel

@sylouuu what may works, you can fork the repo and apply the open prs you need, unfortunately he is busy (I guess) and can't take care of those open prs for now. If you need help with merging some prs that you need let me know I will help you with that.

(just an idea for him to consider) I think is to add some contributor to the repo that can take care of the prs, but I think this was discuss before and he say no (I may be wrong on this sorry if Im )

also he is been really active here (I think is really cool he works for this project so I dont blame him)

https://github.com/mano-sesan/mano

"This is the GitHub repository for MANO, an open-source application developed by Sesan (Société d'Entraide et d'Action pour le Numérique dans les Organisations sociales) — a French organization focused on digital tools for social work.
MANO is a tool designed for street outreach teams and social workers ("maraudes" in French) to help them:

It's essentially a case management and field coordination platform tailored for French social services, particularly those working with homeless populations. The project appears to be a full-stack application with a React Native mobile app (for use in the field), a web dashboard, and a Node.js/Express API backend.
It's backed by the French government's digital transformation efforts (often linked to beta.gouv.fr initiatives)."

@rap2hpoutre
Copy link
Owner

Thank you for your messages, and sorry for the late answer and the lack of support.
I just published this post: #382
@elminson is right about everything btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants