Conversation
|
|
Still waiting for this @rap2hpoutre can someone take a look? 🙇 |
|
This need the version 8.4 added to the matrix to pass all the tests cases fast-excel/.github/workflows/tests.yml Line 18 in a460ac5 please add it and I will take a look after all tests pass @JeppeKnockaert @PNardman |
|
Added it, everything seems to be green! |
elminson
left a comment
There was a problem hiding this comment.
Approving so workflow can be executed
|
Any update on this @rap2hpoutre ? |
|
Any updates? |
|
Hi @rap2hpoutre, do you need any help with this PR? We'd love to get rid of the deprecation warnings in our logs. |
|
@rap2hpoutre any updates here? Would be cool to get rid of the deprecation logs. |
|
Unfortunately, considering moving to https://github.com/spatie/simple-excel |
@sylouuu what may works, you can fork the repo and apply the open prs you need, unfortunately he is busy (I guess) and can't take care of those open prs for now. If you need help with merging some prs that you need let me know I will help you with that. |
(just an idea for him to consider) I think is to add some contributor to the repo that can take care of the prs, but I think this was discuss before and he say no (I may be wrong on this sorry if Im ) also he is been really active here (I think is really cool he works for this project so I dont blame him) https://github.com/mano-sesan/mano "This is the GitHub repository for MANO, an open-source application developed by Sesan (Société d'Entraide et d'Action pour le Numérique dans les Organisations sociales) — a French organization focused on digital tools for social work. It's essentially a case management and field coordination platform tailored for French social services, particularly those working with homeless populations. The project appears to be a full-stack application with a React Native mobile app (for use in the field), a web dashboard, and a Node.js/Express API backend. |
This PR removes implicitly nullable parameters because these result in deprecation warnings for PHP 8.4.
https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter