Skip to content

Conversation

@langyo
Copy link
Contributor

@langyo langyo commented Dec 10, 2023

@langyo langyo marked this pull request as draft December 10, 2023 02:55
@langyo

This comment was marked as outdated.

@langyo langyo marked this pull request as ready for review December 10, 2023 05:14
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally intended this to be fixed in #423, could you please update the wasm-bindgen version here?

Co-authored-by: Kaede Hoshikawa <[email protected]>
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@futursolo futursolo merged commit 3193cd6 into ranile:master Dec 10, 2023
@langyo
Copy link
Contributor Author

langyo commented Dec 10, 2023

@hamza1311 Now gloo-history should be able to release a patch version... Once the patch version is released, yew can officially start review. Could you please take a look?

@futursolo And could you please help me see if this can be merged as soon as possible? yewstack/tokise#11

The original PR is here yewstack/yew#3534

@ranile
Copy link
Owner

ranile commented Dec 11, 2023

Published gloo-history v0.2.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants