Add option to invert rows in spng_encode_image#271
Open
tobybell wants to merge 1 commit intorandy408:masterfrom
Open
Add option to invert rows in spng_encode_image#271tobybell wants to merge 1 commit intorandy408:masterfrom
spng_encode_image#271tobybell wants to merge 1 commit intorandy408:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request is to share back something I implemented in a downstream copy of the project. No pressure to accept it; just sharing in case it's useful.
Previously,
spng_encode_imagewould always interpret theimgdata pointer as pointing to image data in top-to-bottom order, despite some image data APIs storing image data in bottom-to-top order (most notably, OpenGL functions likeglReadPixels).This merge request adds a flag,
SPNG_ENCODE_INVERT_ROWSto allowspng_encode_imageto interpret the given image data pointer as containing rows in bottom-to-top order, instead of top-to-bottom. This allows saving PNG images directly fromglReadPixelscalls when using OpenGL, without an additional copy to reverse the row data.