Skip to content

NEW: specular borders are now optional #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NEW: specular borders are now optional #8

wants to merge 1 commit into from

Conversation

JulienMaille
Copy link

title says it all!

randrew
randrew reviewed Dec 19, 2019
View reviewed changes
Copy link
Owner

@randrew randrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. Please give me a bit of time to go through this -- I want to add some more controls over where the specular highlights can appear (tabs, buttons, etc.) individually. But I think it is a good idea to be able to control this.

@JulienMaille
Copy link
Author

I want to add some more controls over where the specular highlights can appear (tabs, buttons, etc.) individually.

Should be better now.

@JulienMaille JulienMaille requested a review from randrew May 30, 2020 17:46
@JulienMaille
NEW: specular borders are now optional
103a635 
add more granularity to the specular option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randrew randrew Awaiting requested review from randrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienMaille @randrew