Fix Classic McEliece unpoison issue #4605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
approved these changes
Jan 29, 2025
For reasons unknown this caused a side-channel warning from valgrind on aarch64 but not on x86. In any case, this being a sanity-check it is not a side-channel.
Our hypothesis: valgrind on aarch64 fails to properly handle the bit-level 'uninitialized data' tracking here. This is a regression test for the issues seen in #4562.
randombit
force-pushed
the
jack/fix-cmce-unpoison
branch
from
1cd3a05 to
9545c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #4562
@reneme feel free to force push this with signed commits