[v0.7|main] Make admission rejection message more useful for namespace creation #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#47585
Problem
Webhook rejection message was not useful in this situation
Solution
Include user, verb, resource in the rejection message.
Testing notes
To make this situation show up, you can create a roletemplate like the one below
Then you can create a clusterroletemplatebinding to bind that role to a user that has no other permissions on a given cluster.
With that in place, login as the user to which the crtb was bound and navigate to the cluster and try to create a namespace in a project.
Prior to this fix, the error message provided just said "Unauthorized".
After this fix, the error message will look like:
admission webhook "rancher.cattle.io.namespaces.create-non-kubesystem" denied the request: User "u-7qhg2" does not have permission "manage-namespaces" on project "p-w7252"