remove status check from rancher tag and shellcheck action (#502)

* remove status check from rancher

* fix identation

* remove shellcheck

.github/workflows/main.yml

@@ -6,18 +6,6 @@ on:
       - master
 
 jobs:
-  shellcheck:
-    name: Shellcheck
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - name: Run ShellCheck
-        uses: ludeeus/action-shellcheck@master
-        with:
-          severity: info
-          scandir: 'bin/'
-        env:
-          SHELLCHECK_OPTS: -s sh -e SC1091 -e SC2034 -e SC2317
   build:
     name: Build
     runs-on: ubuntu-latest
@@ -28,4 +16,3 @@ jobs:
           make all
           make test
 
-

cmd/release/cmd/tag.go

@@ -23,10 +23,7 @@ type tagRKE2CmdFlags struct {
 	RPMVersion     *int
 }
 
-var (
-	tagRKE2Flags              tagRKE2CmdFlags
-	tagRancherSkipStatusCheck bool
-)
+var tagRKE2Flags tagRKE2CmdFlags
 
 // tagCmd represents the tag command.
 var tagCmd = &cobra.Command{
@@ -178,7 +175,7 @@ var rancherTagSubCmd = &cobra.Command{
 			fmt.Println("dry run, skipping creating release")
 			return nil
 		}
-		releaseURL, err := rancher.CreateRelease(ctx, ghClient, &rancherRelease, opts, preRelease, tagRancherSkipStatusCheck, releaseType)
+		releaseURL, err := rancher.CreateRelease(ctx, ghClient, &rancherRelease, opts, preRelease, releaseType)
 		if err != nil {
 			return err
 		}
@@ -292,9 +289,6 @@ func init() {
 	tagRKE2Flags.ReleaseVersion = rke2TagSubCmd.Flags().StringP("release-version", "r", "r1", "Release version")
 	tagRKE2Flags.RCVersion = rke2TagSubCmd.Flags().String("rc", "", "RC version")
 	tagRKE2Flags.RPMVersion = rke2TagSubCmd.Flags().Int("rpm-version", 0, "RPM version")
-
-	// rancher
-	rancherTagSubCmd.Flags().BoolVarP(&tagRancherSkipStatusCheck, "skip-status-check", "s", false, "skip checking if CI is passing when creating a tag")
 }
 
 func releaseTypePreRelease(releaseType string) (bool, error) {

release/rancher/rancher.go

@@ -313,25 +313,11 @@ func generatePrimeArtifactsHTML(content ArtifactsIndexContentGroup) ([]byte, err
 }
 
 // CreateRelease gets the latest commit in a release branch, checks if CI is passing and creates a github release, returning the created release HTML URL or an error
-func CreateRelease(ctx context.Context, ghClient *github.Client, r *ecmConfig.RancherRelease, opts *repository.CreateReleaseOpts, preRelease, skipStatusCheck bool, releaseType string) (string, error) {
+func CreateRelease(ctx context.Context, ghClient *github.Client, r *ecmConfig.RancherRelease, opts *repository.CreateReleaseOpts, preRelease bool, releaseType string) (string, error) {
 	if !semver.IsValid(opts.Tag) {
 		return "", errors.New("the tag isn't a valid semver: " + opts.Tag)
 	}
 
-	branch, _, err := ghClient.Repositories.GetBranch(ctx, r.RancherRepoOwner, rancherRepo, r.ReleaseBranch, true)
-	if err != nil {
-		return "", err
-	}
-	if branch.Commit.SHA == nil {
-		return "", errors.New("branch commit sha is nil")
-	}
-
-	if !skipStatusCheck {
-		if err := commitStateSuccess(ctx, ghClient, r.RancherRepoOwner, rancherRepo, *branch.Commit.SHA); err != nil {
-			return "", err
-		}
-	}
-
 	releaseName := opts.Tag
 	if preRelease {
 		latestVersionNumber := 1
@@ -363,19 +349,6 @@ func CreateRelease(ctx context.Context, ghClient *github.Client, r *ecmConfig.Ra
 	return createdRelease.GetHTMLURL(), err
 }
 
-func commitStateSuccess(ctx context.Context, ghClient *github.Client, owner, repo, commit string) error {
-	status, _, err := ghClient.Repositories.GetCombinedStatus(ctx, owner, repo, commit, &github.ListOptions{})
-	if err != nil {
-		return err
-	}
-
-	if *status.State != "success" {
-		return errors.New("expected commit " + commit + " to have state 'success', instead, got " + *status.State)
-	}
-
-	return nil
-}
-
 func CheckRancherRCDeps(ctx context.Context, org, gitRef string) (*RancherRCDeps, error) {
 	var content RancherRCDeps
 	files := []string{"Dockerfile.dapper", "go.mod", "/package/Dockerfile", "/pkg/apis/go.mod", "/pkg/settings/setting.go", "/scripts/package-env"}