Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.11] rancher-monitoring 106.0.0+up61.3.2 update #5064

Open
wants to merge 9 commits into
base: dev-v2.11
Choose a base branch
from

Conversation

apoorvajagtap
Copy link

Checkpoints for Chart Bumps

release.yaml:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch or minor version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Chart.yaml and index.yaml:

  • The index.yaml file has an entry for your new chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

Fill the following only if required by your manager.

Issue: rancher/rancher#48830

Additional detail:

Bumps k8s supported version from 1.30.0 to 1.32.0

@apoorvajagtap apoorvajagtap requested a review from a team as a code owner January 31, 2025 18:03
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@apoorvajagtap
Copy link
Author

I did not bump the k8s version for prometheus-federator, as I believe that should be done separately per rancher/rancher#48828?
Let me know, in case we would like to incorporate k8s bump for prometheus-federator chart in this PR itself.

@apoorvajagtap apoorvajagtap force-pushed the monitoring-k8s-rancher-bump branch from adca742 to 3b97d8a Compare January 31, 2025 18:14
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@prachidamle prachidamle requested review from jbiers and a team and removed request for a team February 3, 2025 22:51
@jbiers jbiers self-requested a review February 3, 2025 23:01
Copy link
Member

@jbiers jbiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump the rancher-version annotation too

@apoorvajagtap apoorvajagtap force-pushed the monitoring-k8s-rancher-bump branch from 3b97d8a to 90eab46 Compare February 4, 2025 05:42
Copy link

github-actions bot commented Feb 4, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@apoorvajagtap apoorvajagtap requested a review from jbiers February 4, 2025 05:49
@apoorvajagtap apoorvajagtap force-pushed the monitoring-k8s-rancher-bump branch from 90eab46 to 1adf024 Compare February 4, 2025 17:45
Copy link

github-actions bot commented Feb 4, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@apoorvajagtap apoorvajagtap force-pushed the monitoring-k8s-rancher-bump branch from 1adf024 to d80fb31 Compare February 5, 2025 13:49
Copy link

github-actions bot commented Feb 5, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

github-actions bot commented Feb 5, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link
Member

@jbiers jbiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing but not due to changes in this PR. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants