Fix duplicate fluentbitagent toleartions #5061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
skanakal
force-pushed
the
fix-tolerations
branch
from
7fec92d to
e83196b
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
skanakal
force-pushed
the
fix-tolerations
branch
from
e83196b to
0ccce92
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
| {{- if $isRKE2orK3S }} | ||
| {{- $defaultTolerations = append $defaultTolerations (dict "key" "node-role.kubernetes.io/control-plane" "operator" "Exists" "effect" "NoSchedule") -}} | ||
| {{- else }} | ||
| {{- $defaultTolerations = append $defaultTolerations (dict "key" "node-role.kubernetes.io/controlplane" "operator" "Exists" "effect" "NoSchedule") -}} |
There was a problem hiding this comment.
This doesn't just include RKE1, but EKS and GKE deployments as well, but I don't know off the top of my head if this affects those types of deployments
There was a problem hiding this comment.
yeah that does as the DS managed by fluentbitagent... I have now modified the logic, and I believe it will now reflect the current behavior—using "control-plane" for the rest of the kubernetes distribution. only, thing extra "controlplane" for rke based clusters.
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Rules
Never remove an already released chart!Each Pull Request should only modify one chart with its dependencies.
Pull request title:
<action>: 1 of (bump; remove; UnRC)Checkpoints for Chart Bumps
release.yaml:Chart.yaml and index.yaml:index.yamlfile has an entry for your new chart version.index.yamlentries for each chart matches theChart.yamlfor each chart.Fill the following only if required by your manager.
Issue:
rancher/rancher#48917
Solution
set the tolerations based on the kubernetes distribution
QA Testing Considerations
Already mentioned in the above issue