[dev-v2.10] rancher-monitoring 105.1.3+up61.3.2 update

[jmeza-xyz]

Checkpoints for Chart Bumps

release.yaml:

• Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
• Each chart version in release.yaml IS exactly 1 more patch or minor version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Chart.yaml and index.yaml:

• The index.yaml file has an entry for your new chart version.
• The index.yaml entries for each chart matches the Chart.yaml for each chart.
• Each chart has ALL required annotations
  • kube-version annotation
  • rancher-version annotation
  • permits-os annotation (indicates Windows and/or Linux)

---

Issue: rancher/rancher#48877

Users are not able to install rancher-monitoring chart if global.cattle.systemDefaultRegistry and grafana.imageRenderer.enabled=true is set because the $registry variable include statement is missing an argument from the image-renderer-deployment.yaml template file. Verified the error in rancher v2.10.1 installing chart version 105.1.2+up61.3.2 and confirmed it was introduced in 105.0.0+up57.0.3.

Error from install with setting from image above:

Error: template: rancher-monitoring/charts/grafana/templates/image-renderer-deployment.yaml:68:27: executing "rancher-monitoring/charts/grafana/templates/image-renderer-deployment.yaml" at <include>: wrong number of args for include: want 2 got 1

Solution

This PR changes:

- {{- $registry := include "system_default_registry" | default .Values.imageRenderer.image.registry -}}
+ {{- $registry := include "system_default_registry" . | default .Values.imageRenderer.image.registry -}}

QA Testing Considerations

[github-actions]

Validation steps

• Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  

• Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
• Approve the PR to run the CI check.

[github-actions]

Validation steps

• Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  

• Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
• Approve the PR to run the CI check.

[github-actions]

Validation steps

• Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.

  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  

• Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
• Approve the PR to run the CI check.

[alexandreLamarre]

This should be 105.1.3-rc.1

[alexandreLamarre]

The overlay/crds/crds should be omitted from being committed, IIRC it's an incompatibility with the way monitoring was recently rebased and charts-build-scripts

[mallardduck]

@jmeza-xyz - We're past freeze now and there's a short window for the next release. Please let us know when you update this ASAP, that way it can be properly QAd before the window closes. The bug complete date is Feb 7th.