Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of UUID input on Enter press #558

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Feb 21, 2025

Related Item(s)

#545

Changes

  • When creating a new product, pressing Enter on the UUID input will not move page to editor-main if
    • There is no UUID provided
    • The UUID provided already exists
  • When creating a new product, pressing Enter on the UUID will move page to editor-main if UUID is unique (rather than trying to fetch the product)
  • When loading an existing product, pressing Enter will perform the same logic as the Load button
  • Pressing Load (or Enter) will not attempt to retrieve a product from the server if the UUID field is blank, and will display a more relevant warning message
  • Created new error message for when blank UUID is provided on load existing page

Testing

Steps:

  1. Go to the 'Create New Storylines Product` page
  2. Remove the generated UUID and press Enter
  3. Notice the warning and toast
  4. Enter the UUID of an existing UUID and press Enter
  5. Notice the warning and toast
  6. Enter a unique UUID and press Enter
  7. Notice that you are redirected to editor-main
  8. Go to the Load Existing Storylines Product page
  9. Press enter on the input (without any input)
  10. Notice the warning and toast
  11. Enter a non-existent UUID and press Enter
  12. Notice the warning and toast

This change is Reviewable

@IshavSohal IshavSohal added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Feb 21, 2025
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-545

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IshavSohal)


src/lang/lang.csv line 106 at r1 (raw file):

editor.warning.rename,UUID already in use. Please choose a different ID.,1,UUID déjà utilisé. Veuillez choisir un autre identifiant.,0
editor.warning.blank,UUID field cannot be blank. Please enter a unique UUID.,1,Le champ UUID ne peut pas être vide. Veuillez saisir un UUID unique.,0
editor.warning.blankExisting,UUID field cannot be blank. Please enter a valid UUID to proceed.,1,Le champ UUID ne peut pas être vide. Veuillez saisir un UUID valide pour continuer.,0

Lets just use editor.warning.blank instead.

Copy link
Member Author

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @szczz)


src/lang/lang.csv line 106 at r1 (raw file):

Previously, szczz (Matt Szczerba) wrote…

Lets just use editor.warning.blank instead.

Donethanks

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@mohsin-r mohsin-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

@yileifeng yileifeng merged commit 886beab into ramp4-pcar4:main Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants