Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant schema file, Remove 'modified' prop from schema #532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Feb 10, 2025

Related Item(s)

#491

Changes

  • Removed the redundant StorylinesSchema.json file, since it was not being used anywhere else
  • Prevented the slide-editor component from adding a modified prop to panels
  • Removed the modified prop from the schema
  • Called saveChanges() before executing main logic of panelModified() method, so that unsaved changes are captured and used when comparing the provided panel with its corresponding default config
  • Fixed a few TS errors

Note

  • I was not able to find any other temporary panel properties that break the schema, but let me know if I missed any

Testing

Steps:

  1. Create a new product
  2. Create a new slide
  3. Change the type of a panel to a media panel (ex. Image, Video, Chart)
  4. Notice there is no warning modal
  5. Add some content to the panel (without saving)
  6. Switch the type to another type, and observe the warning modal

This change is Reviewable

@IshavSohal IshavSohal added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Feb 10, 2025
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant