-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign header area #530
base: main
Are you sure you want to change the base?
Redesign header area #530
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/new-header-bar-recreated |
a86973a
to
4e0347b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @IshavSohal, @RyanCoulsonCA, and @yileifeng)
a discussion (no related file):
All comments on the prior PR (#514) should be fixed here. Let me know if anything's been undone that I didn't notice.
4e0347b
to
d87028b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IshavSohal and @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that the product's title remains the same when changing languages.
Also, the editor language toggle still appears for the Canada.ca template, but it also appears for all other pages (dashboard, edit existing product, create new product), so not sure if the issue pertains to this PR.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yileifeng)
d87028b
to
dcaf8fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that the product's title remains the same when changing languages.
This is expected behaviour. The product title language, and other metadata, is controlled by the config language (i.e. the thing you change with the "View English/French Config" button) and not the page language.
Also, the editor language toggle still appears for the Canada.ca template, but it also appears for all other pages (dashboard, edit existing product, create new product), so not sure if the issue pertains to this PR.
Yeah, odd. It seems to be an issue with the URLs used for the "Is this a Canada.ca template?" check. I've fixed it for the editor, new/load product pages, and the dashboard; the language toggle should now hide properly.
Donethanks!
Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)
RECREATION OF PR #514, AS THAT BRANCH WAS HAVING ISSUES
DEPENDS ON #510 (this branch is based on that branch). Pull that first!
Related Item(s)
Issues:
#504
#518
Changes
Leave editor
button and all the save-related UI elements (unsaved changes warning, reset changes button, save button); and the "lower header", containing the product title/UUID and all other buttons (preview, download, etc.)Share feedback
button moved to lower header.Preview
dropdown buttons wider, equal to the width of thePreview
parent button.Notes
Header, desktop, no unsaved changes:
![image](https://private-user-images.githubusercontent.com/75815453/404388587-6d671b27-2c1d-4019-bdb9-6f42e83329b2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjcxMjMsIm5iZiI6MTczOTI2NjgyMywicGF0aCI6Ii83NTgxNTQ1My80MDQzODg1ODctNmQ2NzFiMjctMmMxZC00MDE5LWJkYjktNmY0MmU4MzMyOWIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA5NDAyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzYWFiZDMzN2QzYTQwOGExZjRlMTIwMWY0MWUwYjBlMzBkOTEwZjQ0NzNjODQwMDI3ODZkNWFhMzUwNTZiMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.PYyJTR2LHktL_QLlaHU1hdvQpbmOETnlLncTveFrHvk)
Header, desktop, with unsaved changes:
![image](https://private-user-images.githubusercontent.com/75815453/404388759-be297092-9bdb-4b22-af23-537d6ddd5ce0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjcxMjMsIm5iZiI6MTczOTI2NjgyMywicGF0aCI6Ii83NTgxNTQ1My80MDQzODg3NTktYmUyOTcwOTItOWJkYi00YjIyLWFmMjMtNTM3ZDZkZGQ1Y2UwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA5NDAyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ5ZTc2ZGM0OWM2OTcwMDgyNDM5NGEyZDEwY2U2MGQ1MDAxNmMyM2FjYzIwODlmMmFhNWQxZmI0OWYwMjZiMmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Kp9r4XpJFS4BGZe__cW2M40NdjiX20hL9QyKCEn44l4)
Header, mobile, with unsaved changes and long truncated title:
![image](https://private-user-images.githubusercontent.com/75815453/404390528-6dbb9a38-df05-4574-a49d-b6e76bd208c9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjcxMjMsIm5iZiI6MTczOTI2NjgyMywicGF0aCI6Ii83NTgxNTQ1My80MDQzOTA1MjgtNmRiYjlhMzgtZGYwNS00NTc0LWE0OWQtYjZlNzZiZDIwOGM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDA5NDAyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjM2Y0OGZlMGJiZTVkMzU2NmU5MTQ1NTAyNGVhOTkzYThjNDBjNWJiNmRlMzRkNzQyZGYxYTA1ODRiODRjZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8s9corHnhR5o5YDfdVN1RJt9iJt7ACK9jIs0IbvGPAg)
Testing
Steps:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)