Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite loading spinner when incorrect UUID is provided #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Jan 24, 2025

Related Item(s)

#522

Changes

  • Fixes an issue where the loading spinner never disappeared if a non-existent UUID was provided.

Testing

Steps:

  1. Open the demo link.
  2. Click "Load Existing Storylines Product".
  3. Enter a UUID that doesn't exist.
  4. Ensure that the loading spinner doesn't stick around forever. It should disappear as soon as the "UUID doesn't exist" alert pops up.

This change is Reviewable

@RyanCoulsonCA RyanCoulsonCA added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Jan 24, 2025
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-522

Copy link
Member

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work!

A related problem I've noticed: There used to be a warning when the server isn't available when you try to load the UUID ("Failed to load product, no response from server"), but now it doesn't show anything. If it's not an easy fix, we can create a new issue for this.

image.png

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member Author

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is because of lack of connection to the websocket. When issue 525 is finished, we should display a warning message when there's no websocket connection established, so this one should resolve itself then.

Side note, but that "Failed to load product" string was in lang.csv twice, so I've removed one.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants