fix broken env variable reference when renaming #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCoulsonCA
added
the
PR: Frontend
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Item(s)
#523
Changes
process.env.VUE_APP_NET_API_URLtoimport.meta.env.VITE_APP_NET_API_URLwhen renaming so that the/api/version/update/endpoint is hopefully hit.Notes
Can't say 100% that this will fix the linked issue until we test it on the dev site, but the environment variable should at least be correct now so the POST should be sent.
Testing
This will require the dev site to be updated in order to test.
Steps:
/api/version/update/endpoint is being hit correctly.This change is