-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slide control for including in toc, create config properties for controls #404
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-370-fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IshavSohal)
src/components/slide-editor.vue
line 59 at r1 (raw file):
type="checkbox" class="editor-input rounded-none cursor-pointer w-4 h-4" v-model="includeInToc"
The new checkbox will need a label to prevent a WAVE error!
593ce4d
to
48721d3
Compare
48721d3
to
16af033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)
src/components/slide-editor.vue
line 59 at r1 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
The new checkbox will need a label to prevent a WAVE error!
Good catch, can't believe I missed that lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
Related Item(s)
#370
#394
Changes
Testing
Steps:
includeInToc
is now falsecenterSlide
is now truestory-ramp
repo, within thepublic
directorystory-ramp
repo, open the preview for this product, and observe that the only slides in the toc are the ones for whichincludeInToc
is set to trueThis change is