Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slide control for including in toc, create config properties for controls #404

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Sep 23, 2024

Related Item(s)

#370
#394

Changes

  • Added a slide control checkbox for including a slide in the table of contents (defaults to true)
  • Added all slide controls to the slide's config, so that each slide

Testing

Steps:

  1. Open any product (ex. 00000000-0000-0000-0000-000000000000)
  2. Open the product's config (in vscode)
  3. Go to the first slide and toggle the 'Include in Table of Contents' checkbox to be off
  4. Click save
  5. In the config, observe that for the first slide, includeInToc is now false
  6. Go to any other slide, and observe that the 'Include in Table of Contents' checkbox is on
  7. Toggle the 'Center Slide Content' checkbox to be on
  8. Click save
  9. In the config, observe that for the corresponding slide, centerSlide is now true
  10. Copy the directory containing the config for this product into your local story-ramp repo, within the public directory
  11. Using your local story-ramp repo, open the preview for this product, and observe that the only slides in the toc are the ones for which includeInToc is set to true

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-370-fix

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IshavSohal)


src/components/slide-editor.vue line 59 at r1 (raw file):

                            type="checkbox"
                            class="editor-input rounded-none cursor-pointer w-4 h-4"
                            v-model="includeInToc"

The new checkbox will need a label to prevent a WAVE error!

Copy link
Member Author

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)


src/components/slide-editor.vue line 59 at r1 (raw file):

Previously, RyanCoulsonCA (Ryan Coulson) wrote…

The new checkbox will need a label to prevent a WAVE error!

Good catch, can't believe I missed that lol.

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

@yileifeng yileifeng merged commit e894001 into ramp4-pcar4:main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants