Update toc schema option + add option to toggle nav top #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/edit-toc-feature |
yileifeng
force-pushed
the
edit-toc-feature
branch
from
8ae5a8e to
1fc5171
Compare
RyanCoulsonCA
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Item(s)
https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/9
Changes
Notes
Also wanted to add a minimum UI feature for toggling individual slides to be included/excluded from ToC in preview; however, discovered a shared state / reactivity issue #394 that needs to be fixed first. Since we need these changes for demo tomorrow, we can just modify the new
includeInTocflag through the advanced editor for now.Testing
Try customizing the table of contents navigation menu in preview mode by adding
includeInToc: falsethrough advanced editor for slides as well as toggling the return to top option on the metadata content. Also, ensure background image previews are fixed.This change is