Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix confusing slideshow UI issues #369

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix confusing slideshow UI issues #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/components/slideshow-editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,14 @@
}}</span>

<!-- add item button -->
<button
class="editor-button bg-gray-100 cursor-pointer hover:bg-gray-200"
@click="editingStatus = editingStatus === 'create' ? 'none' : 'create'"
>
<button class="editor-button bg-gray-100 cursor-pointer hover:bg-gray-200" @click="this.changeEditStatus()">
<div class="flex items-center">
<svg
height="18px"
width="18px"
viewBox="0 0 23 21"
xmlns="http://www.w3.org/2000/svg"
v-if="editingStatus === 'none'"
v-if="editingStatus !== 'create'"
>
<path d="M19 13h-6v6h-2v-6H5v-2h6V5h2v6h6v2z" />
</svg>
Expand Down Expand Up @@ -74,7 +71,7 @@
<div>
<div v-if="editingStatus === 'create'">
<!-- Creating new slide -->
<label class="mb-5 text-left">{{ $t('editor.slideshow.label.type') }}:</label>
<label class="mb-5 text-left">{{ $t('editor.slideshow.label.type') }}: </label>
<select @input="onTypeInput" :value="newSlideType">
<option v-for="thing in Object.keys(editors)" :key="thing" :value="thing">
{{ thing }}
Expand All @@ -91,7 +88,11 @@
:allowMany="false"
></component>
<div class="mt-3 w-full flex justify-end">
<button class="editor-button bg-black text-white hover:bg-gray-800" @click="saveItem(true)">
<button
id="add-new-item"
class="editor-button bg-black text-white hover:bg-gray-800"
@click="saveItem(true)"
>
{{ $t('editor.slideshow.label.add') }}
</button>
</div>
Expand Down Expand Up @@ -299,6 +300,19 @@ export default class SlideshowEditorV extends Vue {
saveChanges(): void {
return;
}

changeEditStatus(): void {
if (this.editingStatus === 'create') {
this.editingStatus = 'none';
} else {
this.editingStatus = 'create';

// After switching the edit status, scroll to the add button.
this.$nextTick(() => {
document.getElementById('add-new-item')?.scrollIntoView({ behavior: 'smooth' });
});
}
}
}
</script>

Expand Down
Loading