Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase help panel #351

Merged
merged 1 commit into from
Jul 15, 2024
Merged

rebase help panel #351

merged 1 commit into from
Jul 15, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Jun 20, 2024

Related Item(s)

#264

Changes

  • Rebased Kashish's help panel PR. The only change I've made was to how we're fetching the markdown files in order to fix the issue she was having with loading image.s

Testing

Steps:

  1. Open the demo page and load a product.
  2. There should be a new ? button in the top right. Clicking it should display some help content.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-264

@RyanCoulsonCA RyanCoulsonCA force-pushed the fix-264 branch 4 times, most recently from 06bc9da to 810e6df Compare June 20, 2024 17:50
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need some rebasing if Vite PR is merged but looks good

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member Author

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need some rebasing if Vite PR is merged but looks good

Done!

Reviewable status: 2 of 13 files reviewed, all discussions resolved (waiting on @dnlnashed, @szczz, and @yileifeng)

@yileifeng yileifeng requested review from dnlnashed and szczz July 12, 2024 17:27
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

Not sure if this was due to rebased changes but getting this behavior on initial load on the help icon (transforms to icon after a few seconds).

Reviewable status: 2 of 13 files reviewed, all discussions resolved (waiting on @dnlnashed and @szczz)

Copy link
Member Author

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just moved the source for the material symbols from the Vue component because I was dealing with that same issue. We really don't need to be adding a whole new font just for a question mark so I've removed it entirely and just replaced it with a regular ?.

Reviewable status: 2 of 13 files reviewed, all discussions resolved (waiting on @dnlnashed, @szczz, and @yileifeng)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 11 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dnlnashed and @szczz)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 11 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczz)

@yileifeng yileifeng merged commit 9c77a39 into ramp4-pcar4:main Jul 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants