-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated save messaging and added the storyline title + scrollbar to UUID dropdown #316
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/QOLChanges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title appended to dropdown list items is a nice enhancement. Two notes (one minor one major):
- the current dropdown is not keyboard accessible
- is it worth bolding one of the UUID or title text?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @szczz)
src/components/metadata-editor.vue
line 61 at r1 (raw file):
/> <div class="absolute z-10 w-full bg-white border border-gray-200 mt-1 max-h-96 overflow-y-auto"
Would it be better to make the max-height relative to screen size (e.g. 60vh
)?
… disabled the button until complete. Added the title and a scrollbar to UUID dropdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
donethanks
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @yileifeng)
src/components/metadata-editor.vue
line 61 at r1 (raw file):
Previously, yileifeng (Yi Lei Feng) wrote…
Would it be better to make the max-height relative to screen size (e.g.
60vh
)?
donethanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @szczz)
Updated save messaging / behaviour and added the storyline title + scrollbar to UUID dropdown
Related Item(s)
#301
Changes
[FEATURE] Introduces a scrollbar and the title at the time of saving to the dropdown. Need to discuss bi-lingual title storage in the next meeting.
[REFACTOR] Refactored the versioning system. Mostly done in the .NET API, but I added a warning and disabled the save button until the save is fully complete.
Notes
Can be tested on dev. I used the DevDeployment branch to release this code.
Testing
Steps:
This change is