Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix editor breaking when switching config language #309

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Jun 3, 2024

Related Item(s)

Closes #307 (2/2)

Changes

  • This PR fixes an issue where if you load a product with a logo, switch config languages, and then click 'Next`, the app would break.

Testing

Steps:

  1. Open the sample page.
  2. Load a product that has a logo in both the French and English configs.
  3. Switch the config language and then click the 'Next' button.
  4. Ensure that the app loads correctly.

This change is Reviewable

Copy link

github-actions bot commented Jun 3, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-307-2/#/en/editor

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit 3ec2b09 into ramp4-pcar4:main Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

French preview issues pt. 2
3 participants