Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbar for slides toc #299

Merged
merged 1 commit into from
May 21, 2024

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented May 15, 2024

Related Item(s)

Closes #273

Changes

  • Adds scrollable option for slides section

Testing

Steps:
Scroll on different screen resolutions


This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/slides-toc-scrollbar/#/en/editor

@yileifeng yileifeng changed the title Add scrollbar for slidse toc Add scrollbar for slides toc May 15, 2024
Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@yileifeng yileifeng merged commit 47e7554 into ramp4-pcar4:main May 21, 2024
3 checks passed
@yileifeng yileifeng deleted the slides-toc-scrollbar branch May 21, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbar for slides section in editor
3 participants