-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for centering content #285
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/centered/#/en/editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @KashishMistry)
src/components/editor/slide-editor.vue
line 40 at r1 (raw file):
/> <span class="mx-2 font-bold">{{ $t('editor.slides.centerSlide') }}</span> <input
The toggle checkboxes are not aligned with the text
src/lang/lang.csv
line 115 at r1 (raw file):
editor.slides.makeFull,Make the right panel the full slide,1,Mettre la diapositive complète dans le panneau de droite,1 editor.slides.centerPanel,Align panel content towards the middle,1,Aligner le contenu du panneau vers le milieu,0 editor.slides.centerSlide,Align slide content towards the middle,1,Aligner le contenu de la diapositive vers le milieu,0
Suggestion: how about rewording this to "Center panel content" and "Center slide content"? Would preserve some valuable space as well and could be more intuitive wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @yileifeng)
src/components/editor/slide-editor.vue
line 40 at r1 (raw file):
Donethanks.
src/lang/lang.csv
line 115 at r1 (raw file):
Previously, yileifeng (Yi Lei Feng) wrote…
Suggestion: how about rewording this to "Center panel content" and "Center slide content"? Would preserve some valuable space as well and could be more intuitive wording.
Donethanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)
Related Item(s)
#403 in
story-ramp
repoChanges
story-ramp
repo, however the changes needed to be implemented instorylines-editor
to allow users to manipulate thecustomStyles
property for each panelcenterPanel
allows the user to center content in each panelcenterSlide
allows the user to center content in the overall slide (if the slide has two panels then the left panel is right-aligned and the right panel is left-aligned)Notes
Without centering:

When

centerPanel
is selected:When

centerSlide
is selected:When there is only one panel and

centerSlide
orcenterPanel
is selected:Testing
Steps:
Center panel content
and preview to check the alignment of the content on the panel (should be centered relative to the panel).Center slide content
and preview to check the alignment of the content on the slide (left slide should be right-aligned and right slide should be left-aligned).children
are being aligned correctly.This change is