Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for centering content #285

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

KashishMistry
Copy link
Member

@KashishMistry KashishMistry commented Apr 17, 2024

Related Item(s)

#403 in story-ramp repo

Changes

  • This issue is logged in the story-ramp repo, however the changes needed to be implemented in storylines-editor to allow users to manipulate the customStyles property for each panel
  • centerPanel allows the user to center content in each panel
  • centerSlide allows the user to center content in the overall slide (if the slide has two panels then the left panel is right-aligned and the right panel is left-aligned)

Notes

Without centering:
alignment normal

When centerPanel is selected:
alignment panel

When centerSlide is selected:
alignment slide

When there is only one panel and centerSlide or centerPanel is selected:
alignment one

Testing

Steps:

  1. Create a new slide
  2. Select Center panel content and preview to check the alignment of the content on the panel (should be centered relative to the panel).
  3. Select Center slide content and preview to check the alignment of the content on the slide (left slide should be right-aligned and right slide should be left-aligned).
  4. Experiment with dynamic panels in particular to ensure the panels in children are being aligned correctly.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/centered/#/en/editor

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @KashishMistry)


src/components/editor/slide-editor.vue line 40 at r1 (raw file):

                        />
                        <span class="mx-2 font-bold">{{ $t('editor.slides.centerSlide') }}</span>
                        <input

image.png

The toggle checkboxes are not aligned with the text


src/lang/lang.csv line 115 at r1 (raw file):

editor.slides.makeFull,Make the right panel the full slide,1,Mettre la diapositive complète dans le panneau de droite,1
editor.slides.centerPanel,Align panel content towards the middle,1,Aligner le contenu du panneau vers le milieu,0
editor.slides.centerSlide,Align slide content towards the middle,1,Aligner le contenu de la diapositive vers le milieu,0

Suggestion: how about rewording this to "Center panel content" and "Center slide content"? Would preserve some valuable space as well and could be more intuitive wording.

Copy link
Member Author

@KashishMistry KashishMistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @yileifeng)


src/components/editor/slide-editor.vue line 40 at r1 (raw file):

Previously, yileifeng (Yi Lei Feng) wrote…

image.png

The toggle checkboxes are not aligned with the text

Donethanks.


src/lang/lang.csv line 115 at r1 (raw file):

Previously, yileifeng (Yi Lei Feng) wrote…

Suggestion: how about rewording this to "Center panel content" and "Center slide content"? Would preserve some valuable space as well and could be more intuitive wording.

Donethanks.

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)

@yileifeng yileifeng merged commit b0ec377 into ramp4-pcar4:main May 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants