Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add self-start class to interactive image panel #543

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Feb 10, 2025

Related Item(s)

https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/187

Changes

  • Adds the self-start class to the image section of the interactive image panel. This will make it scroll down with the page if the text panel exceeds the height of the window.

Testing

Steps:

  1. Open the demo link.
  2. Make the window width just large enough that you don't go into mobile view (just around 650px).
  3. Scroll down to the "Interactive image test" slide.
  4. Click on the interactive box on the right side of the image and a bunch of Lorem Ipsum text should show up.
  5. Scroll up and down to view the text, and ensure the image on the left side is fixed to the top of the screen as you scroll.

This change is Reviewable

@RyanCoulsonCA RyanCoulsonCA added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Feb 10, 2025
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-187/#/en/00000000-0000-0000-0000-000000000000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant