-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply lazy load to hosted videos #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @yileifeng)
src/components/panels/video-panel.vue
line 139 at r1 (raw file):
observer.value = new IntersectionObserver(([video]) => { if (video.isIntersecting) { console.log('LOAD VIDEO');
lurking console log
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/lazy-load-video/#/en/00000000-0000-0000-0000-000000000000 |
3c0893f
to
13fb992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @spencerwahl)
src/components/panels/video-panel.vue
line 139 at r1 (raw file):
Previously, spencerwahl (Spencer Wahl) wrote…
lurking console log
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @spencerwahl and @yileifeng)
src/components/panels/video-panel.vue
line 114 at r2 (raw file):
const videoBlobSrc = ref(''); const captionsBlobSrc = ref(''); // const transcriptBlobSrc = ref('');
This can probably be removed too if we're not using it
13fb992
to
2dd3e06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @RyanCoulsonCA and @spencerwahl)
src/components/panels/video-panel.vue
line 114 at r2 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
This can probably be removed too if we're not using it
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spencerwahl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
Related Item(s)
https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/172
Changes
Testing
Steps:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)