Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max height to stickied image panel in mobile view #539

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Feb 4, 2025

Related Item(s)

https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/193
https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/168

Changes

  • Added a max-height to image panels so that very large images will not block the accompanying text panel.
  • Added a minor box shadow under the image panel in order to break up the stickied panel and the text panel.
  • Modified the init function for the interactive map panel to use await instead of Promises since it's an async function.
  • Fixed an error that was popping up in the interactive map panel if the first item was returnHome point and didn't specify a layer ID.

Notes

Open to feedback on the image panel changes! I've compared TCEI product locally with the sandbox site and nothing seems to have changed drastically, other than fixing the super tall image panels.

Testing

Steps:

  1. Open the demo page.
  2. Ensure interactive maps are still working as expected after the changes.
  3. Ensure image panels are working as expected.

This change is Reviewable

Copy link

github-actions bot commented Feb 4, 2025

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-193/#/en/00000000-0000-0000-0000-000000000000

@RyanCoulsonCA RyanCoulsonCA added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Feb 5, 2025
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit 759abb1 into ramp4-pcar4:main Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants