Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeslider append mode #530

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

spencerwahl
Copy link
Member

@spencerwahl spencerwahl commented Jan 9, 2025

Related Item(s)

https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/126

Changes

  • [FEATURE] Adds 'append' mode to timeslider and ability to configure the play mode
  • [FEATURE] Interval between timeslider animation steps is configurable

Notes

New animation config snippet example:

"animation": {
    "playMode": "append",
    "interval": 500
}

Testing

Steps:

  1. Scroll down to the map with a timeslider
  2. Press play and see only the right handle move (and faster than normal!)
  3. See data show up on map but not disappear (until it loops)

This change is Reviewable

Copy link

github-actions bot commented Jan 9, 2025

@spencerwahl spencerwahl force-pushed the timeslider-enhance branch 2 times, most recently from dac6427 to 8958624 Compare January 9, 2025 13:40
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

@spencerwahl spencerwahl merged commit 21c1c3a into ramp4-pcar4:main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants