Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RAMP4 version via github workflow #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dnlnashed
Copy link
Member

@dnlnashed dnlnashed commented Jan 14, 2025

For #86

Changes

This PR adds a github workflow that allows the user to enter a version they want to update RAMP4 to. Accepted versions are ones supported on the RAMP4 npm package. Once ran, the workflow will create a PR containing the updated RAMP4 version.

Notes

  • If the workflow does not work, some repository settings may need to be updated. If you go to Settings -> Actions -> General, select "Allow all actions and reusable workflows" under Action permissions and select "Read and write permissions" and check "Allow Github Actions to create and approve pull requests" under workflow permissions if not already set
  • In main.ts, the .css RAMP4 import ramp-pcar/dist/ramp.css is in a different location for RAMP4 versions 4.8.0 or lower (ramp-pcar/dist/lib/ramp.css). As a result this line needs to be updated when using those versions. The workflow should account for this and change this line accordingly depending on what version you use.
  • Currently this PR updates RAMP4 to 4.10.0 using the npm package

This change is Reviewable

Copy link

Your demo site is ready! 🚀

Main: https://ramp4-pcar4.github.io/ramp-pcar/update-ramp/

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dnlnashed)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dnlnashed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants