Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use ESP Async WebServer v3+ API #596

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dkozel
Copy link

@dkozel dkozel commented Feb 4, 2025

The returned parameter values are const and need to be indexed using size_t not the implicit int type.

This might be reverse compatible with the v2 API, but I haven't tested that. I also haven't done testing of every API endpoint, but all of the logical flows look unaffected by making the returned parameter const.

I see the large PR #551 which removes ESP Async WebServer, but hope this small change will be useful to allow users to compile with the up-to-date library. There's also a documentation update for the wiki which should be done as the two ESP Async libaries have moved repos, I'll open a PR and link it to this one.

This was tested with Arduino 2.3.4, ESP8266 board package 3.1.2, ESP Async TCP 0b6de755, and ESP Async WebServer v3.6.2.

ESP Async TCP is frozen and will not be further developed according to the maintainer as the ESP8266 is considered mature.

The returned parameter values are const and need to be indexed using size_t not the implicit int type.
@dkozel dkozel mentioned this pull request Feb 4, 2025
@dkozel
Copy link
Author

dkozel commented Feb 4, 2025

Realized that the platformio.ini file needed to be updated with the newer dependencies. I also added the esp12a board as I'm using a NodeMCU v3.

@AnvilByte
Copy link

AnvilByte commented Feb 10, 2025

I tested this myself and wifi settings isn't being saved, which is a known issue with ESP8266 board package 3.0+
and using 2.6.3 gives me a "error: missing binary operator before token "(" #if __has_include("ArduinoJson.h")" error, so I don't know what's going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants