Skip to content

Fix scale sensitivity - #11

Merged
rainman110 merged 2 commits into
mainfrom
fix_scale_sensitivity
May 4, 2026
Merged

rainman110 merged 2 commits into
mainfrom
fix_scale_sensitivity

Conversation

@rainman110

Copy link
Copy Markdown
Owner

This PR fixes global scale sensitivity behavior.

Before, scaling up a curve network by some orders on magnitude could result in unsuccessful execution.

There were two places, that contained scale sensitivity:

  1. The computation of the curve curve intersection uses a local optimization. The objective function (point distance) was scale sensitive, resulting in different stopping behaviour. This is now fixed by normalizing the objective function by the local scale.
  2. The reparametrization also contained a scale sensitive stopping criterion, resulting in different run times depending on scale.

@rainman110
rainman110 force-pushed the fix_scale_sensitivity branch from b5524a4 to 6eabde4 Compare May 4, 2026 12:53
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Test Results

83 tests  ±0   83 ✅ ±0   1s ⏱️ -2s
 9 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit 6eabde4. ± Comparison against base commit 1112ef1.

@rainman110
rainman110 merged commit 0dfe953 into main May 4, 2026
2 checks passed
@rainman110
rainman110 deleted the fix_scale_sensitivity branch May 4, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant