-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding custom entrypoint option for charting #911
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenshots and tests?
the tests are here: rain.orderbook/crates/common/src/fuzz/mod.rs Line 856 in 7b882ce
Here is an image of a simple order that contains a scenario with a custom entrypoint and the stack values for that: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please update spec at https://github.com/rainlanguage/specs/blob/main/ob-yaml.md
@thedavidmeister created this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't merge this yet, because dependant branch is not reviewed
Closes #675
Caution
Do not merge before #887
Motivation
See issue: #675
Solution
Scenario
Checks
By submitting this for review, I'm confirming I've done the following: