Merging for yamls #1124
Draft
Merging for yamls #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the app we support having two separate yamls - one for the config (e.g. things in OrderbookYaml) and one for the order itself (DotrainYaml).
At the moment we don't have this functionality for the new yaml structs. We'll need it to refactor DotrainOrder.
Solution
DotrainYaml now accepts a Vec of additional yamls, and those get passed through when matching dependencies. For example, an
Orderbookreferenced by anOrderwill first be looked for in the current document, then the others in order.Shadowing is disallowed per the spec.
Checks
By submitting this for review, I'm confirming I've done the following: