Refactor DotrainOrderGui with new yaml struct changes #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dotrain-order-gui
findolor
changed the title
hardyjosh
reviewed
Jan 6, 2025
| @@ -154,6 +160,114 @@ impl Scenario { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn update_bindings( | |||
There was a problem hiding this comment.
can't see any tests for this?
hardyjosh
reviewed
Jan 6, 2025
| @@ -63,6 +63,165 @@ impl Order { | |||
| pub fn validate_vault_id(value: &str) -> Result<U256, ParseOrderConfigSourceError> { | |||
| U256::from_str(value).map_err(ParseOrderConfigSourceError::VaultParseError) | |||
| } | |||
|
|
|||
| pub fn update_vault_id( | |||
hardyjosh
reviewed
Jan 6, 2025
| Ok(self.clone()) | ||
| } | ||
|
|
||
| pub fn populate_vault_ids(&mut self) -> Result<Self, YamlError> { |
hardyjosh
reviewed
Jan 6, 2025
| @@ -45,12 +46,11 @@ impl DotrainOrderGui { | |||
| return Err(GuiError::TokenNotFound(token_name.clone())); | |||
| } | |||
|
|
|||
| let address = Address::from_str(&address)?; | |||
| select_tokens.insert(token_name.clone(), address); | |||
| let addr = Address::from_str(&address)?; | |||
There was a problem hiding this comment.
why this renaming? is there reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge before #1105
Motivation
See issue: #1035
Solution
Checks
By submitting this for review, I'm confirming I've done the following: