Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1060 withdraw2 task not being executed when withdrawamount is 0 #1082

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ninokeldishvili
Copy link
Contributor

@ninokeldishvili ninokeldishvili commented Dec 16, 2024

Motivation

atm, withdraw2 task is inside of an if block that checks if withdrawAmount is > 0, however bot relies on the task to ensure the bounty of the transaction, and because sometime the bounty can be 0 for one of the tokens, that ends up bypassing the task and as a result, bot fails to ensure the bounty check correctly resulting in negative bounty txs.

Solution

Write test to show the issue

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@ninokeldishvili ninokeldishvili self-assigned this Dec 16, 2024
@hardyjosh hardyjosh removed their request for review December 19, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withdraw2 task not being executed when withdrawAmount is <= 0
2 participants